Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http/sftp: support listening on passed FDs #7801

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Commits on May 13, 2024

  1. http: support listening on passed FDs

    Instead of the listening addresses specified above, rclone will listen to all
    FDs passed by the service manager, if any (and ignore any arguments passed by
    `--{{ .Prefix }}addr`.
    
    This allows rclone to be a socket-activated service. It can be configured as described in
    https://www.freedesktop.org/software/systemd/man/latest/systemd.socket.html
    
    It's possible to test this interactively through `systemd-socket-activate`,
    firing of a request in a second terminal:
    
    ```
    ❯ systemd-socket-activate -l 8088 -l 8089 --fdname=foo:bar -- ./rclone serve webdav :local:test/
    Listening on [::]:8088 as 3.
    Listening on [::]:8089 as 4.
    Communication attempt on fd 3.
    Execing ./rclone (./rclone serve webdav :local:test/)
    2024/04/24 18:14:42 NOTICE: Local file system at /home/flokli/dev/flokli/rclone/test: WebDav Server started on [sd-listen:bar-0/ sd-listen:foo-0/]
    ```
    flokli committed May 13, 2024
    Configuration menu
    Copy the full SHA
    5c8d4e4 View commit details
    Browse the repository at this point in the history
  2. http: fix addr CLI arg help text

    This was missing the fact rclone also supports listening on Unix Domain
    Sockets.
    flokli committed May 13, 2024
    Configuration menu
    Copy the full SHA
    c75c1d8 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    0529828 View commit details
    Browse the repository at this point in the history

Commits on May 15, 2024

  1. lib/sd-activation: wrap coreos/go-systemd

    It fails to build on plan9, which is part of the rclone CI matrix, and
    the PR fixing it upstream doesn't seem to be getting traction.
    
    Stub it on our side, we can still remove this once it gets merged.
    flokli committed May 15, 2024
    Configuration menu
    Copy the full SHA
    cc9ddd6 View commit details
    Browse the repository at this point in the history