Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade dependencies, migrate to vitest #303

Merged
merged 1 commit into from
Jul 29, 2023
Merged

Upgrade dependencies, migrate to vitest #303

merged 1 commit into from
Jul 29, 2023

Conversation

voliva
Copy link
Collaborator

@voliva voliva commented Jul 11, 2023

We were on a quite old version of typescript, jest, etc. so I've tried to upgrade them.

However, I've found a lot of issues trying to get jest to work. Apparently their support for ESModules is still "experimental" and it's a nightmare to set up (specially with typescript in-between).

After trying for an hour I've decided to migrate it to vitest, which is way more out-of-the-box, specially with typescript support.

The only "drawback" is that we need to import the describe/it functions. In theory we don't actually need it because I've set up globals: true, because react-testing-library needs that, but I don't know how to tell typescript that these globals are available only on test files. So anyway, I think it doesn't hurt that much.

Accidentally closes #290 and #294

@codecov
Copy link

codecov bot commented Jul 11, 2023

Codecov Report

Merging #303 (ff1fca7) into main (fb57cdb) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##              main      #303    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           24        24            
  Lines          395      1232   +837     
  Branches        54       141    +87     
==========================================
+ Hits           395      1232   +837     
Files Changed Coverage Δ
packages/utils/src/mergeWithKey.ts 100.00% <100.00%> (ø)

... and 21 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@voliva voliva force-pushed the upgrade-dev-deps branch 3 times, most recently from 65e65bd to f4238d1 Compare July 12, 2023 07:27
Copy link
Member

@josepot josepot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@voliva voliva merged commit 39f9a74 into main Jul 29, 2023
4 checks passed
@voliva voliva deleted the upgrade-dev-deps branch July 29, 2023 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants