[Listbox] Hide input that documentation claims is hidden (#570)

* listbox: hide input (#569) * listbox: simplify unit tests * listbox: simplify another unit test
reach · May 11, 2020 · d8974d6 · d8974d6
1 parent e0e1b09
commit d8974d6
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/packages/listbox/__tests__/listbox.test.tsx b/packages/listbox/__tests__/listbox.test.tsx
@@ -196,7 +196,7 @@ describe("<Listbox />", () => {
             <ListboxOption value="lengua">Lengua</ListboxOption>
           </Listbox>
         );
-        expect(container.querySelector("input")).toBeTruthy();
+        expect(container.querySelector("input")).not.toBeVisible();
       });
     });
 
@@ -218,7 +218,8 @@ describe("<Listbox />", () => {
             </Listbox>
           </div>
         );
-        expect(container.querySelector("input")).toBeTruthy();
+        // Make sure to get the second input (not the one added in the test)
+        expect(container.querySelectorAll("input")[1]).not.toBeVisible();
       });
     });
 
@@ -231,7 +232,7 @@ describe("<Listbox />", () => {
             <ListboxOption value="lengua">Lengua</ListboxOption>
           </Listbox>
         );
-        expect(container.querySelector("input")).toBeTruthy();
+        expect(container.querySelector("input")).not.toBeVisible();
         expect(container.querySelector("input")).toHaveAttribute("required");
       });
     });

diff --git a/packages/listbox/src/index.tsx b/packages/listbox/src/index.tsx
@@ -331,7 +331,7 @@ export const ListboxInput = forwardRef<
             readOnly
             required={required}
             tabIndex={-1}
-            type="text"
+            type="hidden"
             value={state.context.value || ""}
           />
         )}