Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Examples are broken in docs #598

Closed
raunofreiberg opened this issue May 21, 2020 · 5 comments 路 Fixed by #599
Closed

Examples are broken in docs #598

raunofreiberg opened this issue May 21, 2020 · 5 comments 路 Fixed by #599

Comments

@raunofreiberg
Copy link
Contributor

馃悰 Bug report

Current Behavior

image

Expected behavior

Examples should not be broken.

Reproducible example

https://reacttraining.com/reach-ui/listbox (and many other packages affected)

Suggested solution(s)

Track the regression and fix it!

Additional context

I will take a look at this and hopefully come up with a fix.

@raunofreiberg
Copy link
Contributor Author

My gut feeling was that I broke something in #588, but I've traversed the commits back to 196cc56 and the examples are still broken:

image

@chaance
Copy link
Member

chaance commented May 21, 2020

Still broken on prod after the fix. I'll investigate further later today.

@chaance chaance added Type: Documentation Changes to the docs Type: Bug Something isn't working Status: In Progress and removed Type: Bug Something isn't working labels May 21, 2020
@raunofreiberg
Copy link
Contributor Author

Still broken on prod after the fix. I'll investigate further later today.

That's really odd because if I spin up a production build of the website locally, everything is fine!

@raunofreiberg
Copy link
Contributor Author

raunofreiberg commented May 21, 2020

@chancestrickland do you think there might be a problem with caching?

e.g. I see in travis.yml that we cache yarn dependencies:

cache: yarn

Can you try clearing the cache in Travis?

@chaance
Copy link
Member

chaance commented May 22, 2020

It's fixed now. I had changed a sub-dependency in a few packages (descendants) that needed to be released. Thanks again!

@chaance chaance closed this as completed May 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants