Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(website): update lock file #599

Merged
merged 1 commit into from May 21, 2020
Merged

Conversation

raunofreiberg
Copy link
Contributor

@raunofreiberg raunofreiberg commented May 21, 2020

Thank you for contributing to Reach UI! Please fill in this template before submitting your PR to help us process your request more quickly.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code (Compile and run).
  • Add or edit tests to reflect the change (Run with yarn test).
  • Add or edit Storybook examples to reflect the change (Run with yarn start).
  • Ensure formatting is consistent with the project's Prettier configuration.

This pull request:

  • Creates a new package
  • Fixes a bug in an existing package
  • Adds additional features/functionality to an existing package
  • Updates documentation or example code
  • Other

Closes #598

So I don't know since when did the examples get broken, but I tracked this down to a issue with Gatsby: gatsbyjs/gatsby#19827 (comment)

What I did was:

  • rm -rf node_modules && rm -rf .cache
  • yarn remove react react-dom gatsby
  • yarn add react react-dom gatsby

And the examples started working again! Gatsby was also bumped by a minor version which I think is fine.

@raunofreiberg
Copy link
Contributor Author

raunofreiberg commented May 21, 2020

Btw @chancestrickland, do you think there's a chance we could set up PR deployments for the website?

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 0dbe654:

Sandbox Source
little-fast-qvt54 Configuration

@chaance chaance added the Type: Documentation Changes to the docs label May 21, 2020
@chaance
Copy link
Member

chaance commented May 21, 2020

This is so helpful, thank you for the catch and quick fix!

Btw @chancestrickland, do you think there's a chance we could set up PR deployments for the website?

Yes, I would love to have this. I'm probably going to work on moving from Travis to GitHub actions in the next couple of weeks and am going to review the CI setup from top to bottom. I'll make that a priority then.

@chaance chaance merged commit 1b2535f into reach:master May 21, 2020
@raunofreiberg raunofreiberg deleted the fix/website branch May 21, 2020 20:17
@raunofreiberg
Copy link
Contributor Author

Yes, I would love to have this. I'm probably going to work on moving from Travis to GitHub actions in the next couple of weeks and am going to review the CI setup from top to bottom. I'll make that a priority then.

Maybe it would be easier to use Netlify or Vercel for this? 🙂

@chaance
Copy link
Member

chaance commented May 22, 2020

That one's not up to me. It's hosted alongside the React Training website, I imagine it'll stay put for the time being.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Documentation Changes to the docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Examples are broken in docs
2 participants