@reach/tooltip: Export positionTooltip function
#662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows users to re-use this logic in their own apps. In particular, I had a use case where I wanted to change the tooltip offset and the only way I could do so was to copy the definition of the `positionDefault` function. **Note:** I didn't test this (this PR was made from the web interface), just curious if this is something that would be acceptable. Alternatively (and/or additionally), we could add an `offset` prop to the `Tooltip` component.
twavv
changed the title
positionTooltip functionpositionTooltip function
|
Update: Would also be nice to export |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit f6d2b9c:
|
|
Can this be re-opened? @chaance |
|
Sorry for the delay here, but this looks good to me. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows users to re-use this logic in their own apps.
In particular, I had a use case where I wanted to change the tooltip offset and the only way I could do so was to copy the definition of the
positionDefaultfunction.Note: I didn't test this (this PR was made from the web interface), just curious if this is something that would be acceptable. Alternatively (and/or additionally), we could add an
offsetprop to theTooltipcomponent.Thank you for contributing to Reach UI! Please fill in this template before submitting your PR to help us process your request more quickly.
yarn test).yarn start).This pull request: