Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: react 17 compatibility for all packages #716

Merged
merged 2 commits into from
Jan 25, 2021

Conversation

TimKolberger
Copy link
Contributor

@TimKolberger TimKolberger commented Dec 29, 2020

Thank you for contributing to Reach UI! Please fill in this template before submitting your PR to help us process your request more quickly.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code (Compile and run).
  • Add or edit tests to reflect the change (Run with yarn test).
  • Add or edit Storybook examples to reflect the change (Run with yarn start).
  • Ensure formatting is consistent with the project's Prettier configuration.
  • Add documentation to support any new features.

This pull request:

Closes #695

  • Creates a new package
  • Fixes a bug in an existing package
  • Adds additional features/functionality to an existing package
  • Updates documentation or example code
  • Other

I updated deps and peerDeps of react, react-dom and testing utils to allow react versions greater than 17.

@TimKolberger
Copy link
Contributor Author

Just saw #701 👀
I did not encounter any issues after upgrading the testing lib deps.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Dec 29, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 283de2e:

Sandbox Source
reach-ui-template Configuration

@felixmosh
Copy link
Contributor

felixmosh commented Jan 3, 2021

Can it be reviewed & merged pls?

@davibarreira
Copy link

This feature would be great!

@karlhorky
Copy link
Contributor

karlhorky commented Jan 4, 2021

@TimKolberger you can add a note in your issue description above that this "Closes #695" - this will cause GitHub to link the related issue and close is when this PR is merged.

@chaance chaance added the Type: Housekeeping General housekeeping label Jan 25, 2021
@chaance chaance merged commit d0e135d into reach:develop Jan 25, 2021
@TimKolberger TimKolberger deleted the fix/react-17 branch January 25, 2021 22:04
@tannerhuynh
Copy link

Is this not available in 0.15.0?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Housekeeping General housekeeping
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bump react and react-dom peerDependencies version
6 participants