[Fix] calling navigate with number throws #506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- the function `startsWith` was called in any case and was causing an exception to throw when passing `number`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, first thank you for the wonderful job I am using reach router for more than a year now and I am super happy with it ! 馃憦
I am raising this pull request as I faced an issue using
navigatefunction with anumberThe issue
When calling the function
navigatewith anumberas it is mentioned in the documentationIt results into a crash because the function
startsWithrequires astringand is called withtoargumentThe fix
Escaping the case where
toargument is anumber