fix(Overlay): fix arrow animation (#6551)

react-bootstrap · Feb 14, 2023 · 21b9981 · 21b9981
1 parent dd70349
commit 21b9981
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/src/Popover.tsx b/src/Popover.tsx
@@ -101,7 +101,7 @@ const Popover = React.forwardRef<HTMLDivElement, PopoverProps>(
       arrowProps,
       hasDoneInitialMeasure,
       popper,
-      show: _,
+      show,
       ...props
     },
     ref,
@@ -112,7 +112,7 @@ const Popover = React.forwardRef<HTMLDivElement, PopoverProps>(
     const bsDirection = getOverlayDirection(primaryPlacement, isRTL);
 
     let computedStyle = style;
-    if (!hasDoneInitialMeasure) {
+    if (show && !hasDoneInitialMeasure) {
       computedStyle = {
         ...style,
         ...getInitialPopperStyles(popper?.strategy),

diff --git a/src/Tooltip.tsx b/src/Tooltip.tsx
@@ -92,7 +92,7 @@ const Tooltip = React.forwardRef<HTMLDivElement, TooltipProps>(
       arrowProps,
       hasDoneInitialMeasure,
       popper,
-      show: _,
+      show,
       ...props
     }: TooltipProps,
     ref,
@@ -104,7 +104,7 @@ const Tooltip = React.forwardRef<HTMLDivElement, TooltipProps>(
     const bsDirection = getOverlayDirection(primaryPlacement, isRTL);
 
     let computedStyle = style;
-    if (!hasDoneInitialMeasure) {
+    if (show && !hasDoneInitialMeasure) {
       computedStyle = {
         ...style,
         ...getInitialPopperStyles(popper?.strategy),