docs: Add notes about NavLink key behavior #6793
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add note to `collapseOnSelect` based on feedback in react-bootstrap#6654
tjb042
changed the title
kyletsang
reviewed
Apr 19, 2024
| @@ -109,6 +109,9 @@ const propTypes = { | |||
| * Toggles `expanded` to `false` after the onSelect event of a descendant of a | |||
| * child `<Nav>` fires. Does nothing if no `<Nav>` or `<Nav>` descendants exist. | |||
| * | |||
| * `<NavLink>` descentants of `<Nav>` will not trigger the onSelect event unless | |||
There was a problem hiding this comment.
Suggested change
| * `<NavLink>` descentants of `<Nav>` will not trigger the onSelect event unless | |
| * `<NavLink>` descendants of `<Nav>` will not trigger the `onSelect` event unless |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just ran into the issue outlined in PR #6654 and wanted to add an explicit note about it to the API docs to both
NavbarandNavLink