Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow for centered dropdown menus #449

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

allow for centered dropdown menus #449

wants to merge 2 commits into from

Conversation

woro83c
Copy link

@woro83c woro83c commented Sep 5, 2019

RE #295

@bpas247
Copy link
Member

bpas247 commented Sep 5, 2019

just like #446 (comment), we'll need to merge the changes from master into this branch in order for the required status checks to kick off properly.

@woro83c
Copy link
Author

woro83c commented Oct 17, 2019

what still remains on this for it to be merged in?

@taion
Copy link
Member

taion commented Oct 17, 2019

@jquense are you okay with this? this looks like a breaking change.

alternatively, we'd need to keep supporting the old API as a deprecated thing for now. otherwise this would have to be 3.x

@ericyliu
Copy link

what's the status on this PR?

@taion taion requested a review from jquense August 11, 2020 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jquense jquense Awaiting requested review from jquense

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@woro83c @bpas247 @taion @ericyliu