feat: support scoped form instance #660
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #660 +/- ##
==========================================
+ Coverage 99.43% 99.47% +0.03%
==========================================
Files 18 19 +1
Lines 1247 1335 +88
Branches 288 308 +20
==========================================
+ Hits 1240 1328 +88
Misses 7 7 ☔ View full report in Codecov by Sentry. |
lemonied
force-pushed
the
feat-scopedForm
branch
from
8cecf25
to
62c59d7
Compare
zombieJ
reviewed
Mar 12, 2024
src/FormInstanceContext.tsx
Outdated
| import * as React from 'react'; | ||
| import type { InternalFormInstance } from './interface'; | ||
|
|
||
| const FormInstanceContext = React.createContext<InternalFormInstance | undefined>(undefined); |
There was a problem hiding this comment.
能复用 Context 不，List 其实也是加了一个 Scope 理论上来说不用新加一个
There was a problem hiding this comment.
复用FieldContext的话，会造成一个问题：
在子组件里拿到的FormInstance不等于最顶层的Form.useForm()
There was a problem hiding this comment.
想了一下，确实可以用FieldContext传递FormInstance，已修改 @zombieJ
- add hook Form.useFormInstance - Form.useWatch add param "scoped: true"
lemonied
force-pushed
the
feat-scopedForm
branch
from
62c59d7
to
8607178
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ant-design/ant-design#47328