Custom render support for divider #122
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,15794 @@ | |||
| { | |||
| @@ -347,7 +347,11 @@ export default class Pagination extends React.Component { | |||
| onChange={this.handleKeyUp} | |||
| size="3" | |||
| /> | |||
| <span className={`${prefixCls}-slash`}>／</span> | |||
| <span className={`${prefixCls}-divider`} > | |||
There was a problem hiding this comment.
I don't think use itemRender for this feature is a good idea. Maybe just add a prop dividerSymbol for it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi.
This PR adds support for customizing the "slash" divider.
At our company we'd rather display "1 of 30" instead of "1 / 30".
I also added itemRender tests for simple pagination.
Things to keep aware:
I wrapped the slash divider with a
<span>with a styleless class for testing purposes. Could it brake production applications?Also, the first argument of the
itemRenderis the page number(an integer) , which isnt relevant for the divider. I passed the current page, because if I passednull, it could brake production applications that rely on integer methods without null check.Thanks.