Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support tableLayout and column.ellipsis #369

Merged
merged 4 commits into from Sep 3, 2019
Merged

support tableLayout and column.ellipsis #369

merged 4 commits into from Sep 3, 2019

Conversation

afc163
Copy link
Member

@afc163 afc163 commented Sep 3, 2019 •
edited

@afc163 afc163 mentioned this pull request Sep 3, 2019
Merged
14 tasks
@codecov
Copy link

codecov bot commented Sep 3, 2019 •
edited

Codecov Report

Merging #369 into master will decrease coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #369      +/-   ##
==========================================
- Coverage   93.25%   93.22%   -0.03%     
==========================================
  Files          17       17              
  Lines         741      738       -3     
  Branches      216      216              
==========================================
- Hits          691      688       -3     
  Misses         41       41              
  Partials        9        9
Impacted Files Coverage Δ
src/TableHeaderRow.js 97.14% <100%> (ø) ⬆️
src/Table.js 86.06% <100%> (-0.41%) ⬇️
src/TableCell.js 97.91% <100%> (+0.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc86aac...7d561db. Read the comment docs.

@afc163 afc163 merged commit dc0c52c into master Sep 3, 2019
@delete-merged-branch delete-merged-branch bot deleted the ellipsis branch September 3, 2019 09:59
zombieJ
zombieJ reviewed Sep 4, 2019
View reviewed changes
src/Table.js
if (useFixedHeader || scroll.y) {
return true;
}
return false;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这么写用户没有办法设置 tableLayout='auto'

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tableLayout 是默认的，就是不设，antd 里的默认值确实没啥用，我去删掉。

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我改改。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zombieJ zombieJ zombieJ left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@afc163 @zombieJ