fix: overflowY = 'auto' when set scroll.y #973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov Report
@@ Coverage Diff @@
## master #973 +/- ##
==========================================
- Coverage 99.52% 99.49% -0.03%
==========================================
Files 40 36 -4
Lines 3563 989 -2574
Branches 476 320 -156
==========================================
- Hits 3546 984 -2562
+ Misses 17 5 -12
... and 40 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
trongtai37
force-pushed
the
fix/table_scollY
branch
from
6f4e347
to
a146e9b
Compare
zombieJ
reviewed
Aug 15, 2023
| @@ -315,7 +315,7 @@ function Table<RecordType extends DefaultRecordType>(tableProps: TableProps<Reco | |||
|
|
|||
| if (fixHeader) { | |||
| scrollYStyle = { | |||
| overflowY: 'scroll', | |||
| overflowY: 'auto', | |||
There was a problem hiding this comment.
auto will break the width calculation which makes border out of table:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if we set the value of
scroll.ybut the height of all items in the table does not exceedscroll.y, There is still an empty scroll barI think it would be better if we set the
overflowYisauto, the result after the change.