Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support milliseconds picker column (#149) #151

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

MrHeer
Copy link

@MrHeer MrHeer commented May 14, 2019

close #149

@codecov
Copy link

codecov bot commented May 15, 2019

Codecov Report

Merging #151 into master will increase coverage by 0.77%.
The diff coverage is 92.3%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #151      +/-   ##
==========================================
+ Coverage   91.86%   92.63%   +0.77%     
==========================================
  Files           6        6              
  Lines         381      421      +40     
  Branches       99      120      +21     
==========================================
+ Hits          350      390      +40     
  Misses         31       31
Impacted Files Coverage Δ
src/TimePicker.jsx 96.61% <100%> (+2.49%) ⬆️
src/Header.jsx 88.09% <75%> (-0.52%) ⬇️
src/Panel.jsx 92.42% <90%> (+0.89%) ⬆️
src/Combobox.jsx 93.33% <91.66%> (-0.26%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88fa1ba...b871b80. Read the comment docs.

@MrHeer
Copy link
Author

MrHeer commented May 15, 2019

@afc163 If you have time, please review. Thank you very much.

@MrHeer MrHeer closed this Nov 3, 2019
@abney317
Copy link

@MrHeer Why was this closed? I'd like to see this feature merged.

@MrHeer
Copy link
Author

MrHeer commented Jan 28, 2020

@abney317 Because nobody handles it.

@abney317
Copy link

@afc163 Any updates here?

@afc163
Copy link
Member

afc163 commented Feb 2, 2020

You can

@afc163 afc163 reopened this Feb 2, 2020
@vercel
Copy link

vercel bot commented Feb 7, 2020

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/react-component/time-picker/l19wuwlna
✅ Preview: https://time-picker-git-fork-mrheer-feat-issues149.react-component.now.sh

@MrHeer MrHeer requested a review from afc163 February 7, 2020 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support milliseconds picker column
3 participants