Skip to content

Commit

Permalink
Add fixtureLoaded renderer response (#1630)
Browse files Browse the repository at this point in the history
  • Loading branch information
ovidiuch committed Mar 11, 2024
1 parent 4cc91ba commit 0d0e717
Show file tree
Hide file tree
Showing 5 changed files with 110 additions and 1 deletion.
15 changes: 14 additions & 1 deletion packages/react-cosmos-core/src/renderer/rendererConnect.ts
@@ -1,5 +1,9 @@
import { FixtureState } from '../fixtureState/types.js';
import { FixtureId, FixtureList } from '../userModules/fixtureTypes.js';
import {
FixtureId,
FixtureList,
FixtureListItem,
} from '../userModules/fixtureTypes.js';

// FYI: Renderer ids are self assigned in remote environments, so uniqueness
// cannot be established by consensus
Expand Down Expand Up @@ -73,6 +77,14 @@ export type FixtureListUpdateResponse = {
};
};

export type FixtureLoadedResponse = {
type: 'fixtureLoaded';
payload: {
rendererId: RendererId;
fixture: FixtureListItem;
};
};

// Caused by an organic state change inside the renderer. Also dispatched
// after a fixtureSelect request, when rendering stateful components, as their
// initial state is read.
Expand All @@ -98,6 +110,7 @@ export type PlaygroundCommandResponse = {
export type RendererResponse =
| RendererReadyResponse
| RendererErrorResponse
| FixtureLoadedResponse
| FixtureListUpdateResponse
| FixtureStateChangeResponse
| PlaygroundCommandResponse;
Expand Down
32 changes: 32 additions & 0 deletions packages/react-cosmos-renderer/src/__tests__/fixtureSelect.ts
Expand Up @@ -112,3 +112,35 @@ testRenderer(
);
}
);

testRenderer(
'returns fixtureLoaded response for single fixture',
{ rendererId, fixtures },
async ({ selectFixture, fixtureLoaded }) => {
selectFixture({
rendererId,
fixtureId: { path: 'second' },
fixtureState: {},
});
await fixtureLoaded({
rendererId,
fixture: { type: 'single' },
});
}
);

testRenderer(
'returns fixtureLoaded response for multi fixture',
{ rendererId, fixtures },
async ({ selectFixture, fixtureLoaded }) => {
selectFixture({
rendererId,
fixtureId: { path: 'first', name: 'one' },
fixtureState: {},
});
await fixtureLoaded({
rendererId,
fixture: { type: 'multi', fixtureNames: ['one'] },
});
}
);
44 changes: 44 additions & 0 deletions packages/react-cosmos-renderer/src/__tests__/fixtureSelectLazy.ts
@@ -0,0 +1,44 @@
import { uuid } from 'react-cosmos-core';
import { testRenderer } from '../testHelpers/testRenderer.js';
import { wrapActSetTimeout } from '../testHelpers/wrapActSetTimeout.js';
import { wrapDefaultExport } from '../testHelpers/wrapDefaultExport.js';

beforeAll(wrapActSetTimeout);

const rendererId = uuid();
const fixtures = wrapDefaultExport({
first: { one: 'First' },
second: 'Second',
});

testRenderer(
'returns lazy fixtureLoaded response for single fixture',
{ rendererId, fixtures, lazy: true },
async ({ selectFixture, fixtureLoaded }) => {
selectFixture({
rendererId,
fixtureId: { path: 'second' },
fixtureState: {},
});
await fixtureLoaded({
rendererId,
fixture: { type: 'single' },
});
}
);

testRenderer(
'returns lazy fixtureLoaded response for multi fixture',
{ rendererId, fixtures, lazy: true },
async ({ selectFixture, fixtureLoaded }) => {
selectFixture({
rendererId,
fixtureId: { path: 'first', name: 'one' },
fixtureState: {},
});
await fixtureLoaded({
rendererId,
fixture: { type: 'multi', fixtureNames: ['one'] },
});
}
);
Expand Up @@ -45,6 +45,16 @@ export function FixtureProvider(props: Props) {
}
}, [props.fixtureId.path, props.fixtureItem, props.lazy, setLazyItems]);

React.useEffect(() => {
rendererConnect.postMessage({
type: 'fixtureLoaded',
payload: {
rendererId,
fixture: props.fixtureItem,
},
});
}, [props.fixtureItem, rendererConnect, rendererId]);

React.useEffect(() => {
if (!isEqual(state.fixtureState, state.syncedFixtureState)) {
rendererConnect.postMessage({
Expand Down
Expand Up @@ -2,6 +2,7 @@ import until from 'async-until';
import { findLast } from 'lodash-es';
import {
FixtureListUpdateResponse,
FixtureLoadedResponse,
FixtureState,
FixtureStateChangeResponse,
ReloadRendererRequest,
Expand All @@ -23,6 +24,7 @@ export type RendererConnectTestApi = {
fixtureListUpdate: (
payload: FixtureListUpdateResponse['payload']
) => Promise<void>;
fixtureLoaded: (payload: FixtureLoadedResponse['payload']) => Promise<void>;
fixtureStateChange: (
payload: FixtureStateChangeResponse['payload']
) => Promise<void>;
Expand All @@ -43,6 +45,7 @@ export function createRendererConnectTestApi(args: {
setFixtureState,
rendererReady,
fixtureListUpdate,
fixtureLoaded,
fixtureStateChange,
getLastFixtureState,
clearResponses: args.clearResponses,
Expand Down Expand Up @@ -98,6 +101,13 @@ export function createRendererConnectTestApi(args: {
});
}

async function fixtureLoaded(payload: FixtureLoadedResponse['payload']) {
await untilResponse({
type: 'fixtureLoaded',
payload,
});
}

async function fixtureStateChange(
payload: FixtureStateChangeResponse['payload']
) {
Expand Down

0 comments on commit 0d0e717

Please sign in to comment.