-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding date to displayFormat parameters #2086
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this will need tests.
Done :D |
@ljharb can you check it again? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! We still need a test for SingleDatePickerInputController
though.
@mgm793 if you're not interested in finishing this, please leave it open so somebody else can. |
Codecov Report
@@ Coverage Diff @@
## master #2086 +/- ##
===========================================
+ Coverage 0 79.99% +79.99%
===========================================
Files 0 57 +57
Lines 0 2299 +2299
Branches 0 638 +638
===========================================
+ Hits 0 1839 +1839
- Misses 0 271 +271
- Partials 0 189 +189
|
This PR solves this #2085
It pass a date to displayFormat and then user can use this date to format it and return it.