Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update disable prev and next state on month and year change #2169

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

guidosreis
Copy link

Behavior with the current implementation (Next arrow don't get enabled when changing to a previous month on the select):
current

Behavior with the fix:
fix

@ljharb
Copy link
Member

ljharb commented Dec 13, 2021

Thanks! Could you add some tests for this behavior?

@guidosreis
Copy link
Author

Thanks! Could you add some tests for this behavior?

Two tests added

@guidosreis guidosreis force-pushed the fix/2163-update-disable-prev-and-next-state-on-month-and-year-change branch 3 times, most recently from 546a545 to d958c42 Compare December 13, 2021 22:31
@guidosreis
Copy link
Author

@ljharb anything missing?

@guidosreis
Copy link
Author

@ljharb, Is there any reason that it is taking almost one week to re-review this pr?
It would be lovely to create a release out of this fix as soon as possible, so I can fix a bug in our application.
I am sure it will help many other developers as well.

@ljharb
Copy link
Member

ljharb commented Dec 20, 2021

@guidosreis yes, it's the holidays, i have a family, and i'm doing this for free. it might take a month, and that's ok.

test/components/DayPickerRangeController_spec.jsx Outdated Show resolved Hide resolved
test/components/DayPickerRangeController_spec.jsx Outdated Show resolved Hide resolved
test/components/DayPickerRangeController_spec.jsx Outdated Show resolved Hide resolved
test/components/DayPickerRangeController_spec.jsx Outdated Show resolved Hide resolved
test/components/DayPickerRangeController_spec.jsx Outdated Show resolved Hide resolved
test/components/DayPickerRangeController_spec.jsx Outdated Show resolved Hide resolved
test/components/DayPickerRangeController_spec.jsx Outdated Show resolved Hide resolved
test/components/DayPickerRangeController_spec.jsx Outdated Show resolved Hide resolved
@guidosreis guidosreis force-pushed the fix/2163-update-disable-prev-and-next-state-on-month-and-year-change branch from d958c42 to 7335f71 Compare December 20, 2021 17:37
@guidosreis guidosreis force-pushed the fix/2163-update-disable-prev-and-next-state-on-month-and-year-change branch from 7335f71 to ee04403 Compare December 20, 2021 17:41
@guidosreis
Copy link
Author

guidosreis commented Dec 20, 2021

@guidosreis yes, it's the holidays, i have a family, and i'm doing this for free. it might take a month, and that's ok.

You're right, of course you have other priorities.
I was just wondering because it is quite a simple pr compared to others that you usually need to review, luckily for me hehe.
Take your time man, and enjoy the holidays!

@guidosreis
Copy link
Author

Happy birthday to this pull request!!

@aerialist7

This comment was marked as spam.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants