Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert class-based to function-based components #2179

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

hugobessa
Copy link

No description provided.

Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not a welcome change, not always an improvement, and is a breaking change.

Please discuss PRs like this in issues before sending them unsolicited.

@ljharb ljharb added the semver-major: breaking change A non-backwards-compatible change; anything that breaks code - including adding a peerDep. label Jan 26, 2022
@hugobessa
Copy link
Author

Sorry about that. Is there another way I can contribute to support React 17?

@ljharb
Copy link
Member

ljharb commented Jan 26, 2022

That’s blocked on enzyme and airbnb-prop-types supporting it first; no hook or SFC conversion is needed for react 17 support.

@hugobessa
Copy link
Author

Should I close this, @ljharb ?

@ljharb ljharb marked this pull request as draft January 27, 2022 15:29
@ljharb
Copy link
Member

ljharb commented Jan 27, 2022

Let’s just leave it open, as a draft.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-major: breaking change A non-backwards-compatible change; anything that breaks code - including adding a peerDep.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants