Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: acceptPropAsAcceptAttr will return extensions properly #1264

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mseyfayi
Copy link

What kind of change does this PR introduce?

  • Bug Fix
  • Feature
  • Refactoring
  • Style
  • Build
  • Chore
  • Documentation
  • CI

Did you add tests for your changes?

  • Yes, my code is well tested
  • Not relevant

If relevant, did you update the documentation?

  • Yes, I've updated the documentation
  • Not relevant

Summary
File extensions in the accept property were ignored, for example:

useDropzone({
    accept: {
      'image/jpeg': ['.jpg']
    }
  })

This code was accepting .jfif files too.

Does this PR introduce a breaking change?
Non-breaking change.

Other information

@pushcommit
Copy link

pushcommit commented Jan 19, 2023

Can confirm this. Please approve 🙏 Thanks!

@new20121439
Copy link

No one works on this bug fix :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants