Check for debug flag before logging in ga()

react-ga · Sep 14, 2016 · 4cfd94c · 4cfd94c
1 parent ae25344
commit 4cfd94c
Show file tree

Hide file tree

Showing 6 changed files with 22 additions and 7 deletions.
diff --git a/bower.json b/bower.json
@@ -1,6 +1,6 @@
 {
   "name": "react-ga",
-  "version": "2.1.1",
+  "version": "2.1.2",
   "homepage": "https://github.com/react-ga/react-ga",
   "authors": [
     "Tay Yang Shun <tay.yang.shun@gmail.com>"

diff --git a/dist/react-ga.js b/dist/react-ga.js
@@ -158,8 +158,11 @@ var ReactGA = {
   ga: function () {
     if (arguments.length > 0) {
       ga.apply(this, arguments);
-      log('called ga(arguments);');
-      log('with arguments: ' + JSON.stringify([].slice.apply(arguments)));
+      if (_debug) {
+        log('called ga(\'arguments\');');
+        log('with arguments: ' + JSON.stringify([].slice.apply(arguments)));
+      }
+
       return;
     }
 

diff --git a/dist/react-ga.min.js b/dist/react-ga.min.js
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "react-ga",
-  "version": "2.1.1",
+  "version": "2.1.2",
   "description": "React Google Analytics Module.",
   "main": "src/index.js",
   "scripts": {

diff --git a/src/index.js b/src/index.js
@@ -69,8 +69,11 @@ var ReactGA = {
   ga: function () {
     if (arguments.length > 0) {
       ga.apply(this, arguments);
-      log('called ga(arguments);');
-      log('with arguments: ' + JSON.stringify([].slice.apply(arguments)));
+      if (_debug) {
+        log('called ga(\'arguments\');');
+        log('with arguments: ' + JSON.stringify([].slice.apply(arguments)));
+      }
+
       return;
     }
 

diff --git a/test/index.test.js b/test/index.test.js
@@ -90,6 +90,15 @@ describe('react-ga', function () {
         ['send', 'pageview', '/mypage']
       ]);
     });
+
+    it('should output debug info, if debug is on', function () {
+      ReactGA.initialize('foo', { debug: true });
+      ReactGA.ga('send', 'pageview', '/mypage');
+      console.info.args.should.eql([
+        ['[react-ga]', "called ga('arguments');"],
+        ['[react-ga]', 'with arguments: ["send","pageview","/mypage"]']
+      ]);
+    });
   });
 
   /**