[POC] Allow string default position #271
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Since
react-draggable
relies on transform, it can sometimes be difficult to create components that rely themselves on transform, since transformations will be overidden by react-draggable.This PR especially solves #223. Indeed, the only way to center a floating div on the screen is to use a
transform(-50%, -50%)
.So, I added the possibility to provide the
defaultPosition
as a string.Cool stuffs:
defaultPosition
, this is good for centeringBad stuffs:
calc
, I am not sure if this is good / cross-browser / IE compatibletransform
generation, which reduce performance (but is it significant ?), instead of using thedefaultPosition
only during the component construction.