feat(React): add nodeRef prop
#478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If running in React Strict mode, ReactDOM.findDOMNode() is deprecated.
Unfortunately, in order for <Draggable> to work properly, we need raw access
to the underlying DOM node. If you want to avoid the warning, pass a `nodeRef`
as in this example:
function MyComponent() {
const nodeRef = React.useRef(null);
return (
<Draggable nodeRef={nodeRef}>
<div ref={nodeRef}>Example Target</div>
</Draggable>
);
}
This can be used for arbitrarily nested components, so long as the ref ends up
pointing to the actual child DOM node and not a custom component.
Thanks to react-transition-group for the inspiration.
`nodeRef` is also available on <DraggableCore>.
|
Looks like nodeRef is missing in typings |
daylesalmon
pushed a commit
to wmcadigital/wmn-disruptions
that referenced
this pull request
May 21, 2020
daylesalmon
added a commit
to wmcadigital/wmn-disruptions
that referenced
this pull request
May 22, 2020
* Updated packages * Fixed a "cannot set state on unmounted...." error being casued by resize event listeners * Implement fix for draggable as per: react-grid-layout/react-draggable#478. Fixes #160 - Draggable causes console.error. * Ensure the view is ready. * Added a default of blank for value on autocomplete * Started to fix weird scroll to error happening on map * Moved click event to its own custom hook so it updates click handlers as the maps state changes * Fixed typos * Removed console.log
Does it added now? |
|
Nope, I had this issue on version 4.4.2 which is still the latest one |
STRML
added a commit
that referenced
this pull request
Jun 5, 2020
STRML
added a commit
that referenced
this pull request
Jun 5, 2020
|
Released in v4.4.3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If running in React Strict mode, ReactDOM.findDOMNode() is deprecated.
Unfortunately, in order for to work properly, we need raw access
to the underlying DOM node. If you want to avoid the warning, pass a
nodeRefas in this example:
This can be used for arbitrarily nested components, so long as the ref ends up
pointing to the actual child DOM node and not a custom component.
Thanks to react-transition-group for the inspiration.
nodeRefis also available on .Supersedes #430
Fixes #440, #465