Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(grid): incorrect x and y passed to onStop #507

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Commits on Jul 29, 2020

  1. fix(grid): incorrect x and y passed to onStop

    This was caused by `onStop` erroneously recalculating coordinates,
    which is not necessary / should not happen in the real world, as `mouseup`
    and `touchend` should not pass `clientX` and `clientY` values meaningfully
    different than the last corresponding move event. In fact, they are already
    ignored by `<Draggable>`.
    
    For this reason, we can simply trust the `lastX` and `lastY` in `onDragStop`,
    and pass those back.
    
    Fixes #413, bokuweb/react-rnd#453
    STRML committed Jul 29, 2020
    Configuration menu
    Copy the full SHA
    8d95806 View commit details
    Browse the repository at this point in the history