Avoid unwanted re-render on resize #1705
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While digging into the source code of the library to investigate a runtime crash I had in one of my app, I found this quick optimization. I though it could still be useful to share it but feel free to reject it if it does not make sense.
Up-to-now the current implementation watches the event
onWindowResize
and triggers a state update anytime it receives an event related to resize even if the size of the offset was not updated.The PR just removes this unneeded re-render by not updating the state in such case.