Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RTL Support #96

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add RTL Support #96

wants to merge 2 commits into from

Conversation

Roshdy
Copy link

@Roshdy Roshdy commented Feb 7, 2019

Related Issue #95
Adding RTL direction resizing

Add direction property to handle mouse movement based on layout direction ["ltr"/"rtl"]
Set background image & positioning based on direction ["ltr"/"rtl"]
@Roshdy
Copy link
Author

Roshdy commented Feb 12, 2019

@STRML Kindly review and comment

@Roshdy
Copy link
Author

Roshdy commented Feb 18, 2019

Dear @STRML

PLEASE review the pull request and the same topic in react-grid-layout .

Much appreciated.

@STRML
Copy link
Collaborator

STRML commented Feb 18, 2019

Hi @Roshdy - I am not working on open source for the next week or so. Please just use github resolved packages in your project until I have time to get to this.

@AnandMathew
Copy link

HI @STRML, will this be merged?

@rayray93
Copy link

Hi @STRML @Roshdy, great work with this grid package... thumbs up! ;)
is there way to get that rtl support ?

@david1824
Copy link

Hi, any updates about this issue?

FIY ant.design provides example with this library for their table component. link

@matijamatija
Copy link

Hey, any luck with this?

@sapter
Copy link

sapter commented Oct 24, 2021

@Roshdy with the latest version (3.0.4), it looks like sw and se cases are already handled via the new .react-resizable-handle-sw and .react-resizable-handle-se classes. Is it fair to say that the only thing we need to add is a direction optional prop to Resizable.js and a different background-image for RTL?

@Roshdy
Copy link
Author

Roshdy commented Oct 25, 2021

@sapter I'll check out my changes and get back to you on that. It's been a long time since i've made these changes.

@sayjeyhi
Copy link

sayjeyhi commented Nov 21, 2021

up! @Roshdy any updates

@ghost
Copy link

ghost commented Jun 14, 2022

@Roshdy +1 for adding support for this

@arthemishapa
Copy link

@Roshdy +1 for RTL support and any updates

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants