🐞 fix #10131 regression on NaN data type (#10132)

react-hook-form · Mar 18, 2023 · b6b16a7 · b6b16a7
1 parent 6f5e69c
commit b6b16a7
Show file tree

Hide file tree

Showing 2 changed files with 39 additions and 1 deletion.
diff --git a/src/__tests__/useForm/formState.test.tsx b/src/__tests__/useForm/formState.test.tsx
@@ -875,4 +875,40 @@ describe('formState', () => {
       });
     });
   });
+
+  it('should return updated value with NaN data type', async () => {
+    function App() {
+      const { register, formState } = useForm({
+        mode: 'onChange',
+        defaultValues: {
+          value: '',
+        },
+      });
+
+      return (
+        <form>
+          {formState.errors.value && <p>error</p>}
+          <input
+            {...register('value', {
+              min: 0,
+              valueAsNumber: true,
+              validate: (value) => !Number.isNaN(value),
+            })}
+          />
+        </form>
+      );
+    }
+
+    render(<App />);
+
+    fireEvent.change(screen.getByRole('textbox'), {
+      target: {
+        value: '2a',
+      },
+    });
+
+    await waitFor(() => {
+      screen.getByText('error');
+    });
+  });
 });
diff --git a/src/logic/createFormControl.ts b/src/logic/createFormControl.ts
@@ -745,7 +745,9 @@ export function createFormControl<
           )
         )[name];
 
-        isFieldValueUpdated = fieldValue === get(_formValues, name, fieldValue);
+        isFieldValueUpdated =
+          isNaN(fieldValue) ||
+          fieldValue === get(_formValues, name, fieldValue);
 
         if (isFieldValueUpdated) {
           if (error) {