Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

馃悶 fix #10139 useFieldArray array error not updating in some cases #10150

Merged
merged 2 commits into from
Mar 21, 2023
Merged

馃悶 fix #10139 useFieldArray array error not updating in some cases #10150

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e257e93
Add test for useFieldArray array error updating on array change
kylemclean Mar 21, 2023
d7223a0
Fix useFieldArray array error not updating sometimes (#10139)
kylemclean Mar 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
161 changes: 161 additions & 0 deletions src/__tests__/useFieldArray.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -551,6 +551,167 @@ describe('useFieldArray', () => {
expect(screen.queryByText('minLength')).not.toBeInTheDocument(),
);
});

it('should update error when array is changed', async () => {
const App = () => {
const {
register,
control,
formState: { errors },
} = useForm<{
test: { value: string }[];
}>({
mode: 'onChange',
resolver: (data) => {
const errors: { test?: any } = {};
if (data.test.length > 4) {
errors.test = { type: 'toobig', message: 'WAY too many items' };
} else if (data.test.length > 3) {
errors.test = { type: 'toobig', message: 'Too many items' };
}
for (const [index, item] of data.test.entries()) {
if (item.value === '') {
errors.test = errors.test || [];
errors.test[index] = {
value: { type: 'required', message: 'Required' },
};
}
}

return {
values: data,
errors,
};
},
defaultValues: {
test: [{ value: '0' }, { value: '1' }, { value: '2' }],
},
});
const { fields, append, remove } = useFieldArray({
name: 'test',
control,
});

return (
<form>
{errors.test?.type && <p>Array error: {errors.test.message}</p>}
{fields.map((item, i) => (
<div key={item.id}>
<input {...register(`test.${i}.value` as const)} />
<button type="button" onClick={() => remove(i)}>
remove
</button>
{errors.test?.[i]?.value && (
<span>
Item {i} error: {errors.test?.[i]?.value?.message}
</span>
)}
</div>
))}
<button
type="button"
onClick={() =>
append({
value: fields.length.toString(),
})
}
>
append
</button>
</form>
);
};

render(<App />);

await waitFor(() =>
expect(screen.queryByText('Array error:')).not.toBeInTheDocument(),
);

fireEvent.click(screen.getByRole('button', { name: 'append' }));

await waitFor(() =>
expect(
screen.queryByText('Array error: Too many items'),
).toBeInTheDocument(),
);

fireEvent.click(screen.getByRole('button', { name: 'append' }));

await waitFor(() =>
expect(
screen.queryByText('Array error: WAY too many items'),
).toBeInTheDocument(),
);

fireEvent.click(screen.getAllByRole('button', { name: 'remove' })[0]);

await waitFor(() =>
expect(
screen.queryByText('Array error: Too many items'),
).toBeInTheDocument(),
);

fireEvent.click(screen.getAllByRole('button', { name: 'remove' })[0]);

await waitFor(() =>
expect(screen.queryByText('Array error:')).not.toBeInTheDocument(),
);

fireEvent.change(screen.getAllByRole('textbox')[0], {
target: { value: '' },
});

await waitFor(() =>
expect(
screen.queryByText('Item 0 error: Required'),
).toBeInTheDocument(),
);

fireEvent.click(screen.getByRole('button', { name: 'append' }));

await waitFor(() => {
expect(
screen.queryByText('Array error: Too many items'),
).toBeInTheDocument();
expect(
screen.queryByText('Item 0 error: Required'),
).toBeInTheDocument();
});

fireEvent.click(screen.getByRole('button', { name: 'append' }));

await waitFor(() => {
expect(
screen.queryByText('Array error: WAY too many items'),
).toBeInTheDocument();
expect(
screen.queryByText('Item 0 error: Required'),
).toBeInTheDocument();
});

fireEvent.click(screen.getAllByRole('button', { name: 'remove' })[4]);

await waitFor(() => {
expect(
screen.queryByText('Array error: Too many items'),
).toBeInTheDocument();
expect(
screen.queryByText('Item 0 error: Required'),
).toBeInTheDocument();
});

fireEvent.click(screen.getAllByRole('button', { name: 'remove' })[3]);

await waitFor(() => {
expect(
screen.queryByText('Array error: Too many items'),
).not.toBeInTheDocument();
expect(
screen.queryByText('Item 0 error: Required'),
).toBeInTheDocument();
});
});
});

describe('when component unMount', () => {
Expand Down
18 changes: 6 additions & 12 deletions src/useFieldArray.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -323,18 +323,12 @@ export function useFieldArray<
if (control._options.resolver) {
control._executeSchema([name]).then((result) => {
const error = get(result.errors, name);
const existingError = get(control._formState.errors, name);

if (
existingError ? !error && existingError.type : error && error.type
) {
error
? set(control._formState.errors, name, error)
: unset(control._formState.errors, name);
control._subjects.state.next({
errors: control._formState.errors as FieldErrors<TFieldValues>,
});
}
error
? set(control._formState.errors, name, error)
: unset(control._formState.errors, name);
control._subjects.state.next({
errors: control._formState.errors as FieldErrors<TFieldValues>,
});
});
} else {
const field: Field = get(control._fields, name);
Expand Down