Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release @react-icons/all-files #593

Open
maddhruv opened this issue Sep 1, 2022 · 11 comments
Open

release @react-icons/all-files #593

maddhruv opened this issue Sep 1, 2022 · 11 comments
Labels

Comments

@maddhruv
Copy link

maddhruv commented Sep 1, 2022

Describe the bug
Looks like @react-icons/all-files hasn't been released lately with react-icons so I am missing the newly added icons packs

Minimal sample repository
Not Required

Expected behavior
For example Tabler Icons are missing from all-files, Can you please do a release with latest react-icons

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • Device: [e.g. PC, iPhone6]
  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

Additional context
Add any other context about the problem here.

@maddhruv
Copy link
Author

maddhruv commented Sep 1, 2022

@kamijin-fanta

@SukkaW
Copy link

SukkaW commented Sep 1, 2022

@maddhruv I believe it is caused by too many files generated, causing npm to refuse to host the package.

Here is what happened when I was trying to publish the package under my own npm scope:

image

@maddhruv
Copy link
Author

maddhruv commented Sep 1, 2022

I think by npm pack and npm publish --tarball` using the tarball you would be able to publish, can you please try

@maddhruv
Copy link
Author

maddhruv commented Sep 5, 2022

Hey @nolanleung looks like with the latest release as well, the all-files package is not updated. Can you look into this?

@kamijin-fanta
Copy link
Member

I tried to publish, but it was rejected due to too many files. I think I need to plan on splitting the package.

@SukkaW
Copy link

SukkaW commented Oct 14, 2022

I tried to publish, but it was rejected due to too many files. I think I need to plan on splitting the package.

One possible solution is to split the ESM and CJS packages, which could reduce the number of files to half.

@kamijin-fanta
Copy link
Member

kamijin-fanta commented Oct 14, 2022

I don't think that is a good solution. Currently the package contains 80,000 files, which is causing problems such as long installation times. Also, the number of icons will continue to increase.

@codsane
Copy link

codsane commented Dec 30, 2022

I don't think that is a good solution. Currently the package contains 80,000 files, which is causing problems such as long installation times. Also, the number of icons will continue to increase.

While it may defeat the purpose of having a package named "all-files", maybe the icons could be split up into packages based on their icon library? So, a @react-icons/fa package, a @react-icons/hi package, and so-on?

@fregante
Copy link

Those packages already exist but they don't contain the separate icons. The main setup should just be fixed to export single files in each package and then you should deprecate this duplicate "all-icons" package.

@Wolverin-e
Copy link

To all the people still finding a workaround, we can also do: npm install link_to_gzipped_tarball.

For an Example:

$ npm i https://github.com/react-icons/react-icons/releases/download/v4.7.1/react-icons-all-files-4.7.1.tgz

This also adds a dependency in the package.json file.

References:

@stephenasuncionDEV
Copy link

When is this being updated?

GriffinBaxter added a commit to GriffinBaxter/GriffinBaxter.com that referenced this issue Apr 25, 2024
This had to be updated using the GitHub download becuase of react-icons/react-icons#593
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

7 participants