Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RQ-510] fix: updated react-icons imports for improving bundle size #931

Merged
merged 1 commit into from Aug 11, 2023

Conversation

wrongsahil
Copy link
Member

@wrongsahil wrongsahil commented Aug 10, 2023

πŸ“œ Summary of changes:

Bundle Size decreased from 6.6MB -> 3.4MB (50% improvement)

Using imports from @react-icons/all-files
react-icons/react-icons#154 (comment)

Installing react-icons from github releases as npm isn't supported for latest versions
react-icons/react-icons#593 (comment)

βœ… Checklist:

  • Make sure linting and unit tests pass.
  • No install/build warnings introduced.
  • Verified UI in browser.
  • For UI changes, added/updated analytics events (if applicable).
  • For changes in extension's code, manually tested in Chrome and Firefox.
  • For changes in extension's code, both MV2 and MV3 are covered.
  • Added/updated unit tests for this change.
  • Raised pull request to update corresponding documentation (if already exists).

πŸ§ͺ Test instructions:

πŸ”— Other references:

@wrongsahil wrongsahil changed the title fix: updated react-icons imports for improving bundle size [RQ-510] fix: updated react-icons imports for improving bundle size Aug 11, 2023
@wrongsahil wrongsahil merged commit 5d42897 into master Aug 11, 2023
1 check passed
@wrongsahil wrongsahil deleted the update-react-icons-import branch August 11, 2023 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants