Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Keyboard Shortcut to focus directly on search input field #799

Closed
wants to merge 1 commit into from
Closed

Conversation

kimtaejin3
Copy link
Contributor

@kimtaejin3 kimtaejin3 commented Aug 18, 2023

issue #797

People around me also thought it would be great for the React Icon website to have this feature, so I implemented this

  • widow and others
shortcut01
  • macOs
shortcut02

note

  • I changed the font size of the search input to 1.1em to display the shortcut key in it.

** I tested this feature on the site locally and it all worked fine **

@kimtaejin3
Copy link
Contributor Author

kimtaejin3 commented Aug 21, 2023

@kamijin-fanta Can you give me a review that says something is lacking or not worth merging? That would be very helpful to me..

@kamijin-fanta kamijin-fanta added the preview-site(low priority) About preview web site label Sep 7, 2023
@kimtaejin3 kimtaejin3 closed this Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
preview-site(low priority) About preview web site
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants