Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add icon attribution in aria-details #815

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

jasperfirecai2
Copy link
Contributor

@jasperfirecai2 jasperfirecai2 commented Sep 13, 2023

An attempt at using the already in-scope license info to add attribution to Icon components.
Example reference from fontawesome when you download an svg from their website:

<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 448 512"><!--! Font Awesome Pro 6.4.2 by @fontawesome - https://fontawesome.com License - https://fontawesome.com/license (Commercial License) Copyright 2023 Fonticons, Inc. --><path d="M0 96C0 60.7 28.7 32 64 32H384c35.3 0 64 28.7 64 64V416c0 35.3-28.7 64-64 64H64c-35.3 0-64-28.7-64-64V96z"/></svg>

Also looked into using HTML comments but that requires using dangerouslySetInnerHTML or refs, and conflicts with using children.

Very open to discussion and suggestions. Builds from pipelines dont seem to reflect any changes so i'm a little confused.

@kamijin-fanta
Copy link
Member

Thanks for your contribution. Good idea! Sorry, the build process is very complex. I will look into the possibility of rewriting the code for better performance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants