Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Resolve incorrect rendering of some colored icons #830

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kimtaejin3
Copy link
Contributor

@kimtaejin3 kimtaejin3 commented Nov 4, 2023

I solved the issue I mentioned in #827

@kamijin-fanta @gorangajic Could you please review this?

  • Before I fix it
image image
  • After I fix it
image image

@kimtaejin3 kimtaejin3 force-pushed the fix-svg-fill-issue branch 2 times, most recently from abb710c to 1a16cb1 Compare November 5, 2023 01:59
@kimtaejin3 kimtaejin3 changed the title Fix: Resolve issue with incorrect rendering of icons due to SVG fill attribute removal Fix: Resolve issue with incorrect rendering of some colored icons Nov 5, 2023
@kimtaejin3 kimtaejin3 changed the title Fix: Resolve issue with incorrect rendering of some colored icons Fix: Resolve incorrect rendering of some colored icons Nov 5, 2023
@soseonghyeon
Copy link

soseonghyeon commented Nov 7, 2023

@kamijin-fanta When is this going to be merged? I want to use GrChrome in Grommet Icons but now I can't use this

@kamijin-fanta
Copy link
Member

@kimtaejin3 Thanks for your contribution.

If multiColor is enabled, changing the color of icons with color props will not work. grommet-Icons include some colored icons, but most are single-color icons.

Twotone in Ant Design Icons may be good with mutiColor enabled.

@kimtaejin3
Copy link
Contributor Author

@kamijin-fanta Thanks for replying! Then why don't you enable multicolor only for Twotone in Ant Design Icons? I think we need to think more about Grommet Icons

@kamijin-fanta
Copy link
Member

I have looked into what happened with grommet-Icons.

✅OK / ⚠OK, but color is overrided / 🚫NG

The library adds stroke="currentColor" fill="currentColor" when drawing SVG. However, this seems to be overridden if fill="none" is specified in the SVG tag. I think the top-level fill can be removed. However, it needs to be investigated if it does not break compatibility.

Twotone in Ant Design Icons should be included in the library update.

kamijin-fanta added a commit that referenced this pull request Nov 14, 2023
@kamijin-fanta
Copy link
Member

This change will be released as v4.12.0.

ccfbc00

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants