Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.0.0 Fix Chip close icon #770

Conversation

iSarCasm
Copy link

@iSarCasm iSarCasm commented Mar 10, 2019

Description

Fixes #769

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Tested with storybook. Updated enzyme specs for Chip.

Checklist:

  • My changes generate no new warnings
  • I have not generated a new package version. (the maintainers will handle that)

@alextrastero
Copy link
Member

Looks good, I'll restart CI

@iSarCasm
Copy link
Author

@alextrastero I think this is some Travis+Jest specific problem jestjs/jest#8069

@alextrastero
Copy link
Member

Tried a different test to see if CI passes: #789

@iSarCasm iSarCasm deleted the 3.0.0-beta.0-fix_chip_close branch March 29, 2019 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants