Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve get photos logic per Jared Sumner's solution #171

Closed
wants to merge 4 commits into from
Closed

Improve get photos logic per Jared Sumner's solution #171

wants to merge 4 commits into from

Conversation

guy-shahine
Copy link

@guy-shahine guy-shahine commented May 7, 2020

Summary

We're facing slow performance speed when loading photos. Jared Sumner provided a solution that's explained in more details in #138 and other related issues are #110 and #168

NOTE: CameraRollExample doesn't work in Xcode 11+ because it requires an upgrade of React Native.

Test Plan

Since it's an improvement, I ran the existing tests and got no failures.

What's required for testing (prerequisites)?

  1. Run CameraRollExample project
  2. Accept access to photo albums
  3. Observe the images load speed

What are the steps to reproduce (after prerequisites)?

Compatibility

OS Implemented
iOS
Android N/A

Checklist

  • I have tested this on a device and a simulator
  • I added the documentation in README.md
  • I updated the typed files (TS and Flow)
  • I added a sample use of the API in the example project (example/App.js)

@pribeh
Copy link

pribeh commented May 8, 2020

Quadruple pump this.

@gordonwhitehouse
Copy link

Yes please. I quintuple pump this

@guy-shahine guy-shahine deleted the enhancement/faster-photos-load-speed branch May 13, 2020 14:53
@guy-shahine guy-shahine restored the enhancement/faster-photos-load-speed branch May 13, 2020 14:53
@pribeh
Copy link

pribeh commented May 25, 2020

@guy-shahine why did you close the pr?

@guy-shahine
Copy link
Author

@pribeh multiple reasons:
a) The package is still wired with an old structure and versions that prevents it from compiling with latest xcode
b) The tests passed but then I discovered a bug in Jared's code where a variable name was missing so tests are unreliable
c) I managed to get the example project to run in simulator but can't run on device (it requires an older iOS version that I don't have available)
d) No feedback, follow up or engagement from the maintainers

@pribeh
Copy link

pribeh commented May 27, 2020

@guy-shahine thanks for sharing and your effort to implement this – I understand

@guy-shahine guy-shahine deleted the enhancement/faster-photos-load-speed branch June 5, 2020 20:00
@tvpranav
Copy link

@guy-shahine Have we got any solution for thumbnail of images to make it more faster?

@guy-shahine
Copy link
Author

guy-shahine commented Jan 19, 2021

@tvpranav We couldn't solve it using this library so we changed our logic to use a different library that invokes the native photo picker.

@TitoSniberb
Copy link

@tvpranav We couldn't solve it using this library so we changed our logic to use a different library that invokes the native photo picker.

Could you please tell me the library you are using? We are trying to implement a gallery but it's impossible on iOS since the memory leak and the slow performance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants