-
Notifications
You must be signed in to change notification settings - Fork 432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve get photos logic per Jared Sumner's solution #171
Improve get photos logic per Jared Sumner's solution #171
Conversation
Quadruple pump this. |
Yes please. I quintuple pump this |
…ve-cameraroll into enhancement/faster-photos-load-speed
@guy-shahine why did you close the pr? |
@pribeh multiple reasons: |
@guy-shahine thanks for sharing and your effort to implement this – I understand |
@guy-shahine Have we got any solution for thumbnail of images to make it more faster? |
@tvpranav We couldn't solve it using this library so we changed our logic to use a different library that invokes the native photo picker. |
Could you please tell me the library you are using? We are trying to implement a gallery but it's impossible on iOS since the memory leak and the slow performance |
Summary
We're facing slow performance speed when loading photos. Jared Sumner provided a solution that's explained in more details in #138 and other related issues are #110 and #168
NOTE: CameraRollExample doesn't work in Xcode 11+ because it requires an upgrade of React Native.
Test Plan
Since it's an improvement, I ran the existing tests and got no failures.
What's required for testing (prerequisites)?
What are the steps to reproduce (after prerequisites)?
Compatibility
Checklist
README.md
example/App.js
)