fix: always add --verbose to the command
#1953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Need to update snapshots |
szymonrybczak
force-pushed
the
fix/commander
branch
from
2f4fd61
to
3e0b8eb
Compare
thymikee
approved these changes
Jun 5, 2023
adamTrz
approved these changes
Jun 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Recently we added
.enablePositionalOptions()to the commander, and this caused one problem, because we specified--verbosedirectly to thereact-nativeso we were able to doreact-native --verbose, but if we didreact-native run-android --verboseit didn't work - so the solution for this is to add--verboseto every command.Test Plan:
npx react-native -v<- should give version of CLInpx react-native --verbose<- shouldn't worknpx react-native run-android --verbose<- should pass verbose torun-android