Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Upgrading Metro dependencies to 0.77.0 #2007

Merged
merged 2 commits into from
Jul 11, 2023

Conversation

arushikesarwani94
Copy link
Contributor

Summary:

Updating the versions of Metro in the cli-plugin-metro to incorporate the new Metro Release v0.77.0.
https://github.com/facebook/metro/releases/tag/v0.77.0

Per the release notes shared below, this is a breaking change for RN CLI including bumping minimum Node version to 18, using Terser's default for comments and removing metro-minify-uglify from metro dependencies

Metro release notes:

NOTE: Experimental features are not covered by semver and can change at any time.

Full Changelog: facebook/metro@v0.76.7...v0.77.0

Reminder: When React Native updates the CLI to a version that depends on metro 0.77.0, it must also update metro-runtime etc to 0.77.0 in the same commit.

Test Plan:

✅ yarn build
✅ yarn test

Copy link
Collaborator

@szymonrybczak szymonrybczak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! FYI I re-ran the e2e tests and they are passing now ✅

@thymikee thymikee merged commit 8ff2278 into react-native-community:main Jul 11, 2023
6 checks passed
@@ -27,7 +27,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
node-version: [16, 18]
node-version: [18]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this include Node 20 as well? (It's the Current version, will be LTS in October)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, I think we can cover this change as part of #1986

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants