more

react-native-community · Jan 22, 2020 · bb2e3d9 · bb2e3d9
1 parent c0e8cdf
commit bb2e3d9
Show file tree

Hide file tree

Showing 2 changed files with 60 additions and 1 deletion.
diff --git a/src/components/common/VersionSelector.js b/src/components/common/VersionSelector.js
@@ -3,7 +3,7 @@ import styled from 'styled-components'
 import { Button, Popover } from 'antd'
 import semver from 'semver/preload'
 import queryString from 'query-string'
-import R from 'ramda'
+import * as R from 'ramda'
 
 import { RELEASES_URL } from '../../utils'
 import { Select } from './'
@@ -120,8 +120,10 @@ export const filterReleases = (
 
   switch (showRCs) {
     case 'all':
+      // show all rcs
       break
     case 'latest': {
+      // show only latest version's rcs
       let latestRelease = filteredReleases[0]
       let earliestLatestReleaseIndex = R.findIndex(
         release =>
@@ -140,12 +142,29 @@ export const filterReleases = (
       break
     }
     case 'none':
+      // don't show any rcs
       filteredReleases = R.reject(isRC)(filteredReleases)
       break
     default:
       break
   }
 
+  if (maxVersion !== undefined) {
+    // drop all versions later than `maxVersion`
+    filteredReleases = R.dropWhile(
+      release =>
+        semver.compare(semver.coerce(release), semver.coerce(maxVersion)) > 0
+    )(filteredReleases)
+  }
+
+  if (minVersion !== undefined) {
+    // take all versions later or equal to `minVersion`
+    filteredReleases = R.takeWhile(
+      release =>
+        semver.compare(semver.coerce(release), semver.coerce(minVersion)) >= 0
+    )(filteredReleases)
+  }
+
   return filteredReleases
 }
 

diff --git a/src/components/common/VersionSelector.test.js b/src/components/common/VersionSelector.test.js
@@ -30,6 +30,34 @@ const releasesNoRCsWithLatestReleaseRCs = [
   '0.63.2-rc.0',
   ...releasesNoRCs
 ]
+const releasesBeforeMax = [
+  '0.62.4',
+  '0.62.4-rc.1',
+  '0.62.4-rc.0',
+  '0.62.3',
+  '0.62.1',
+  '0.62.0',
+  '0.62.0-rc.1',
+  '0.61.3'
+]
+const releasesAfterMin = [
+  '0.63.2-rc.1',
+  '0.63.2-rc.0',
+  '0.63.1',
+  '0.63.0',
+  '0.62.4',
+  '0.62.4-rc.1',
+  '0.62.4-rc.0',
+  '0.62.3',
+  '0.62.1'
+]
+const releasesBetweenMinAndMax = [
+  '0.62.4',
+  '0.62.4-rc.1',
+  '0.62.4-rc.0',
+  '0.62.3',
+  '0.62.1'
+]
 
 describe('release filtering', () => {
   it('should return the correct releases', () => {
@@ -41,5 +69,17 @@ describe('release filtering', () => {
     expect(filterReleases(releases, { showRCs: 'latest' })).toEqual(
       releasesNoRCsWithLatestReleaseRCs
     )
+
+    expect(filterReleases(releases, { maxVersion: '0.62.4' })).toEqual(
+      releasesBeforeMax
+    )
+
+    expect(filterReleases(releases, { minVersion: '0.62.1' })).toEqual(
+      releasesAfterMin
+    )
+
+    expect(
+      filterReleases(releases, { minVersion: '0.62.1', maxVersion: '0.62.4' })
+    ).toEqual(releasesBetweenMinAndMax)
   })
 })