Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix package name and app name replacement #376

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

M7mdisk
Copy link

@M7mdisk M7mdisk commented Feb 20, 2024

Summary

the app name and package name were not being properly changed inside the diff files, only in the diff path, this is happening because the tokenizer is using the old hunks instead of updatedHunks. I also added getHunksWithAppName as a dependency to make sure the files are automatically updated when the app name or package name are changed. This isn't introducing any new features, simply fixing what appears to be a bug.

Test Plan

Before:

image

After:

image

What are the steps to reproduce?

Checklist

  • I tested this thoroughly
  • I added the documentation in README.md (if needed)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant