Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BottomSheet] add customizable fade animation #3849

Open
wants to merge 3 commits into
base: next
Choose a base branch
from

Conversation

onmotion
Copy link

@onmotion onmotion commented Oct 15, 2023

Motivation

The current animation for displaying the BottomSheet relies on a modal approach, resulting in the backdrop appearing simultaneously with the content at the bottom of the screen.

Screen.Recording.2023-10-15.at.17.16.53.mov

Fixes # (issue)

Type of change

  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

    Extension is fully backward compatible, except of backgroundColor moved from safeAreaView styles to backdrop styles which are also customizable

  • This change requires a documentation update
    Added new properties

How Has This Been Tested?

Run example BottomSheet

  • Jest Unit Test
  • Checked with example app

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation using yarn docs-build-api
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Additional context

Slide

Simulator.Screen.Recording.-.iPhone.15.-.2023-10-15.at.16.33.53.mp4

Fade

Simulator.Screen.Recording.-.iPhone.15.-.2023-10-15.at.16.34.17.mp4

None

Simulator.Screen.Recording.-.iPhone.15.-.2023-10-15.at.16.34.05.mp4

@onmotion onmotion marked this pull request as ready for review October 15, 2023 16:02
Copy link

codecov bot commented Jan 29, 2024

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (c87b7ec) 79.70% compared to head (4eaf35e) 79.64%.

Files Patch % Lines
packages/base/src/BottomSheet/BottomSheet.tsx 71.42% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             next    #3849      +/-   ##
==========================================
- Coverage   79.70%   79.64%   -0.07%     
==========================================
  Files          87       87              
  Lines        1843     1857      +14     
  Branches      819      828       +9     
==========================================
+ Hits         1469     1479      +10     
- Misses        369      373       +4     
  Partials        5        5              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants