Allow users to get rid of scroll warning when rendering a flatlist in…

[ali139713]

…side bottomsheet.

Motivation

Fixes # (issue)

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How Has This Been Tested?

• Jest Unit Test
• Checked with example app

Checklist

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation using yarn docs-build-api
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• Any dependent changes have been merged and published in downstream modules

Additional context

[vegtelenseg]

I think this view, just like ScrollView should take some props.

[ali139713]

Yes, But I think this is already keeping it simple. Would you like to add to this change ?

…

On Sun, May 5, 2024 at 9:04 AM Siya ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In packages/base/src/BottomSheet/BottomSheet.tsx <#3901 (comment)> : > @@ -69,8 +70,12 @@ export const BottomSheet: RneFunctionComponent<BottomSheetProps> = ({ pointerEvents="box-none" {...rest} > - <View> - <ScrollView {...scrollViewProps}>{children}</ScrollView> + <View> + {disableScroll ? ( + <View>{children}</View> I think this view, just like ScrollView should take some props. — Reply to this email directly, view it on GitHub <#3901 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AMYJ3LNZ3H2HK24CJIWR4F3ZAWVWBAVCNFSM6AAAAABHCUZ2EOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDAMZZGU3TQMBSHE> . You are receiving this because you authored the thread.Message ID: <react-native-elements/react-native-elements/pull/3901/review/2039578029@ github.com>