New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Failed to build when RCT_NEW_ARCH_ENABLED=1
#2252
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR is pretty important! |
Feels like this should be an easy merge |
Saved me, huge thanks!!! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found this working.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works for me in "react-native": "0.73.4"
## [7.1.1](v7.1.0...v7.1.1) (2024-03-13) ### Bug Fixes * **ios:** fix spec name when new architecture is enabled ([#2252](#2252)) ([df78b9a](df78b9a))
🎉 This PR is included in version 7.1.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Thanks for submitting a PR! Please read these instructions carefully:
main
branch, NOT a "stable" branch.Motivation (required)
I use your package for the example of my react-native library in react-native 0.73.
When I build my example with the new architecture enable, I face the issue:
Full logs is available here: https://github.com/apivideo/api.video-reactnative-uploader/actions/runs/7142227360/job/19451072582#logs
What existing problem does the pull request solve?
I think the reason it fails it is because the interface should implement
NativeImagePickerSpec
instead ofRNImagePickerSpec
.See https://reactnative.dev/docs/0.72/the-new-architecture/pillars-turbomodules#rtncalculatorh
Test Plan (required)
As I am not super familiar with RN, I could not find a way to build your library with
RCT_NEW_ARCH_ENABLED=1
.Is there a way to build your library for iOS?
Anyway, I tested to locally change
ImagePickerManager.h
in my local project and it did fix the compilation issue.You can check that my project is not building with the following commands: