feat: Enable new arch for the example project #5033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Migrated unsupported APIs - enabled the new architecture for the iOS example app with MapKit.
- example for android is working as well
- increase android build memory
GETAWAY-Dev
previously approved these changes
Apr 13, 2024
- attempting to fix the android CI by version bumping reanimated, reset cache
- attempting to fix the android CI by version bumping reanimated, reset cache
GETAWAY-Dev
previously approved these changes
Apr 13, 2024
- attempting to fix CI by removing support for arm64-v8a for the example project
added 2 commits
April 13, 2024 20:50
- using pickFirst for now
- pickfirst for all instead of exclude
GETAWAY-Dev
previously approved these changes
Apr 13, 2024
- pickFirst .so / c++ libs from android builds - exclude META-INF
- remove reanimated from example due to import issues - update dependencies
GETAWAY-Dev
approved these changes
Apr 14, 2024
|
🎉 This PR is included in version 1.14.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does any other open PR do the same thing?
No
What issue is this PR fixing?
New arch will be turned on by default in RN 0.74, to prepare for it we need to have the example app running new arch and make it available so that library users can test and provide early feedback.
How did you test this PR?
On a physical device for both android and iOS (MapKit)
todo: iOS GoogleMaps