Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix statusBarTranslucent height #630

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mwegener-com
Copy link

Issue: #571

@mmazzarolo
Copy link
Member

mmazzarolo commented Dec 8, 2021

Thanks for the PR!
This will probably require some testing before being merged to ensure it works on different use cases:

  • iPhone with and without notch
  • Android devices with and without the bottom bar enabled
  • Modals with scrollable content
  • ensuring everything works while rotating the device

Is anyone willing to give it a try + add screenshots/videos? (doesn't necessary need to be done by a single contributor 👍 )

src/modal.tsx Outdated Show resolved Hide resolved
Co-authored-by: yahacom <yahacomua@gmail.com>
@jzxchiang1
Copy link

I can confirm this fixes my problem on Android as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants