New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix exception due to deprecated removeEventListener on RN 70.X #713

Open

punndcoder28 wants to merge 1 commit into react-native-modal:master from punndcoder28:fix_deprecation_exception

punndcoder28 commented Dec 7, 2022

Overview

This should fix the exception caused due to removeEventListener being deprecated in the newer RN versions, rendering the library to not be used on the projects using latest RN version

Test Plan

Need some help here, do not exactly know how to test the changes, but on our product, when I did the similar change we did not face any crashes due to exception


          fix: fix exception due to deprecated removeEventListener on RN 70.X

f9e39ba

punndcoder28 requested a review from mmazzarolo as a code owner

December 7, 2022 07:05

stephanrotolante commented Jan 25, 2023

@punndcoder28 bless u 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment