Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Add support for Bridgeless Mode - 0.74 #1508

Merged
merged 1 commit into from Mar 16, 2024

Conversation

cortinico
Copy link
Contributor

Overview

I've been testing Bridgeless mode in 0.74 RC3 and realized that the library is broken on Android. Here the fix

Test Plan

Before After
untitled2 untitled

@cortinico
Copy link
Contributor Author

Did you manage to test this with iOS? For some reason the build is failing here: app.circleci.com/pipelines/github/react-native-share/react-native-share/1268/workflows/12a63623-4147-4ba5-af43-a8babe907804/jobs/4761?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-checks-link&utm_content=summary.

Nope I havent' but I'm also not touching the iOS code at all 🤷

@brentvatne
Copy link
Contributor

@MateusAndrade - that failure looks unrelated to this change, it seems the detox installation steps needs to be updated:

==> Tapping wix/brew
Cloning into '/usr/local/Homebrew/Library/Taps/wix/homebrew-brew'...
remote: Enumerating objects: 747, done.        
remote: Counting objects: 100% (203/203), done.        
remote: Compressing objects: 100% (94/94), done.        
remote: Total 747 (delta 100), reused 188 (delta 91), pack-reused 544        
Receiving objects: 100% (747/747), 1.60 MiB | 17.08 MiB/s, done.
Resolving deltas: 100% (387/387), done.
Tapped 1 cask and 2 formulae (18 files, 1.6MB).
Error: Tapping homebrew/cask is no longer typically necessary.
Add --force if you are sure you need it done.

Exited with code exit status 1

@brentvatne brentvatne merged commit e57ed36 into react-native-share:main Mar 16, 2024
2 of 3 checks passed
@brentvatne
Copy link
Contributor

@MateusAndrade - fixed it here #1509

MateusAndrade pushed a commit that referenced this pull request Mar 22, 2024
# [10.1.0](v10.0.2...v10.1.0) (2024-03-22)

### Features

* **android:** Add support for Bridgeless Mode - 0.74 ([#1508](#1508)) ([f78ebab](f78ebab))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants