fix: move codegen spec file from outside of src to src #1528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mym0404
requested review from
jgcmarins,
MateusAndrade and
mikehardy
as code owners
MateusAndrade
approved these changes
May 17, 2024
MateusAndrade
pushed a commit
that referenced
this pull request
May 17, 2024
## [10.2.1](v10.2.0...v10.2.1) (2024-05-17) ### Bug Fixes * **codegen:** move codegen spec file from outside of src to src ([#1528](#1528)) ([b02da4d](b02da4d))
|
🎉 This PR is included in version 10.2.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
fix #1527 fix #1440
Looking at the results built with bob builder,
src/index.tsxrefers to the correct path about codegen spec, but themoduledoes not.Therefore, we move the codegen spec path into src and simplify the appearance of the lint command.
Web imports their dependencies from
modulecommonly, and I know this package doesn't support web yet.Test Plan
yarn validateyarn pack