Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove log statement that breaks react-native-community autolinking config #3367

Merged
merged 1 commit into from Mar 28, 2024

Conversation

brentvatne
Copy link
Contributor

@brentvatne brentvatne commented Mar 28, 2024

When running a build in a project without a react-native.config.js with the log in metro.config.js catch block:

FAILURE: Build failed with an exception.

* Where:
Script '/Users/brent/code/with-webview/node_modules/@react-native-community/cli-platform-android/native_modules.gradle' line: 442

* What went wrong:
A problem occurred evaluating script.
> Calling `[node, /Users/brent/code/with-webview/node_modules/@react-native-community/cli/build/bin.js, config]` finished with an exception. Error message: groovy.json.JsonException: Unable to determine the current character, it is not a string, number, array, or object

  The current character read is 'H' with an int value of 72
  Unable to determine the current character, it is not a string, number, array, or object
  line number 1
  index number 0
  Hello? Error: Failed to find `react-native.config.js`
  ^. Output: Hello? Error: Failed to find `react-native.config.js`
      at configureProjects (/Users/brent/code/with-webview/node_modules/react-native-test-app/scripts/configure-projects.js:169:11)

As an aside - I don't know much about react-native-test-app, but I'm somewhat surprised it has anything to do with the config that is being run anywhere outside of the context of when you are building the app.

@brentvatne brentvatne merged commit 81fe8e0 into master Mar 28, 2024
11 checks passed
@brentvatne brentvatne deleted the @brent/fix-log branch March 28, 2024 01:13
@brentvatne
Copy link
Contributor Author

merged quickly because it's a hotfix

react-native-community-bot pushed a commit that referenced this pull request Mar 28, 2024
## [13.8.4](v13.8.3...v13.8.4) (2024-03-28)

### Bug Fixes

* Remove log statement that breaks react-native-community autolinking config ([#3367](#3367)) ([81fe8e0](81fe8e0))
@react-native-community-bot
Copy link
Collaborator

🎉 This PR is included in version 13.8.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants