Attempted useMemo to no avail #303
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LOVE that you're tackling this! I'll take a look. |
|
believe useMemo doesn't work here because line 372 will always be newly defined, so the defaultCodeValue will change every time https://github.com/react-syntax-highlighter/react-syntax-highlighter/pull/303/files#diff-6214d870917fc8dbaf180113af76d2f1a674571612cd92e1f5500c04d159ac48R372 , using a useMemo on that with the depenency being |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my initial attempt at fixing #302. Unfortunately React gives an invalid hook call warning: https://reactjs.org/warnings/invalid-hook-call-warning.html. I'm guessing the issue has something to do with have a function return a functional component. I checked and don't seem to have mismatched React versions. If anyone has any ideas, please do let me know!
We also need to upgrade dependency versions since 16.8 is the earliest React release that has hooks.